godfreyhe commented on a change in pull request #17962:
URL: https://github.com/apache/flink/pull/17962#discussion_r760095374
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdColumnUniqueness.scala
##########
@@ -81,22 +77,11 @@ class FlinkRelMdColumnUniqueness private extends
MetadataHandler[BuiltInMetadata
return false
}
- // TODO get uniqueKeys from TableSchema of TableSource
-
- relOptTable match {
- case table: FlinkPreparingTableBase => {
- val ukOptional = table.uniqueKeysSet
- if (ukOptional.isPresent) {
- if (ukOptional.get().isEmpty) {
- false
- } else {
- ukOptional.get().exists(columns.contains)
- }
- } else {
- null
- }
- }
- case _ => rel.getTable.isKey(columns)
+ val uniqueKeys =
FlinkRelMdUniqueKeys.INSTANCE.getTableUniqueKeys(relOptTable)
Review comment:
I prefer we can get unique keys through public API: `mq.getUniqueKeys()`
instead of depending on `FlinkRelMdUniqueKeys` class directly.
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdColumnUniqueness.scala
##########
@@ -81,22 +77,11 @@ class FlinkRelMdColumnUniqueness private extends
MetadataHandler[BuiltInMetadata
return false
}
- // TODO get uniqueKeys from TableSchema of TableSource
-
- relOptTable match {
- case table: FlinkPreparingTableBase => {
- val ukOptional = table.uniqueKeysSet
- if (ukOptional.isPresent) {
- if (ukOptional.get().isEmpty) {
- false
- } else {
- ukOptional.get().exists(columns.contains)
- }
- } else {
- null
- }
- }
- case _ => rel.getTable.isKey(columns)
+ val uniqueKeys =
FlinkRelMdUniqueKeys.INSTANCE.getTableUniqueKeys(relOptTable)
+ if (uniqueKeys != null) {
+ uniqueKeys.exists(columns.contains)
Review comment:
We should consider another case: `rel.getTable.isKey(columns)` if
`uniqueKeys.exists(columns.contains)` is false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
