JingsongLi commented on a change in pull request #17542:
URL: https://github.com/apache/flink/pull/17542#discussion_r760725040



##########
File path: 
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/utils/ParquetSchemaConverter.java
##########
@@ -101,11 +110,32 @@ private static Type convertToParquetType(
             case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
                 return Types.primitive(PrimitiveType.PrimitiveTypeName.INT96, 
repetition)
                         .named(name);
+            case ARRAY:
+                ArrayType arrayType = (ArrayType) type;
+                return ConversionPatterns.listOfElements(
+                        repetition,
+                        name,
+                        convertToParquetType(LIST_ELEMENT_NAME, 
arrayType.getElementType()));
+            case MAP:
+                MapType mapType = (MapType) type;
+                return ConversionPatterns.stringKeyMapType(

Review comment:
       must be string key?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to