JingsongLi commented on a change in pull request #17542:
URL: https://github.com/apache/flink/pull/17542#discussion_r760729158
##########
File path:
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java
##########
@@ -120,15 +144,18 @@ private void innerTest(Configuration conf, boolean
utcTimestamp) throws IOExcept
toDateTime(v),
BigDecimal.valueOf(v),
BigDecimal.valueOf(v),
- BigDecimal.valueOf(v)));
+ BigDecimal.valueOf(v),
+ new Integer[] {v},
+ mapData,
+ Row.of(String.valueOf(v), v)));
}
ParquetWriterFactory<RowData> factory =
- ParquetRowDataBuilder.createWriterFactory(ROW_TYPE, conf,
utcTimestamp);
+ ParquetRowDataBuilder.createWriterFactory(ROW_TYPE_COMPLEX,
conf, utcTimestamp);
BulkWriter<RowData> writer =
factory.create(path.getFileSystem().create(path,
FileSystem.WriteMode.OVERWRITE));
for (int i = 0; i < number; i++) {
- writer.addElement(CONVERTER.toInternal(rows.get(i)));
+ writer.addElement(CONVERTER_COMPLEX.toInternal(rows.get(i)));
}
writer.flush();
writer.finish();
Review comment:
I think you need add assert below. No validation for written data.
Maybe you can use something like
`ParquetAvroStreamingFileSinkITCase.readParquetFile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
