luoyuxia commented on a change in pull request #17990:
URL: https://github.com/apache/flink/pull/17990#discussion_r761058266
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveGenericUDTF.java
##########
@@ -157,4 +165,16 @@ public TypeInformation getResultType() {
public void close() throws Exception {
function.close();
}
+
+ public static StandardStructObjectInspector
getStandardStructObjectInspector(
+ ObjectInspector[] argumentInspectors) {
+ List<String> structFieldNames = new ArrayList<>();
+ for (int i = 0; i < argumentInspectors.length; i++) {
+ structFieldNames.add(String.valueOf(i));
Review comment:
It seems like it's ok to set a arbitrary value here for we will still
set colum name in function GenericUDTF.initialize().
But could you like to add some comments here for it's confused.
And I think `dummy_col_1` , `dummy_col_1` may be better for the column's
name.
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveGenericUDTF.java
##########
@@ -157,4 +165,16 @@ public TypeInformation getResultType() {
public void close() throws Exception {
function.close();
}
+
+ public static StandardStructObjectInspector
getStandardStructObjectInspector(
+ ObjectInspector[] argumentInspectors) {
+ List<String> structFieldNames = new ArrayList<>();
+ for (int i = 0; i < argumentInspectors.length; i++) {
+ structFieldNames.add(String.valueOf(i));
Review comment:
It seems like it's ok to set a arbitrary value here for we will still
set colum name in function GenericUDTF.initialize().
But could you like to add some comments here for it's confused?
And I think `dummy_col_1` , `dummy_col_1` may be better for the column's
name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
