luoyuxia commented on a change in pull request #17990:
URL: https://github.com/apache/flink/pull/17990#discussion_r761061239
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java
##########
@@ -635,6 +636,35 @@ public void testTemporaryFunction() throws Exception {
tableEnv.executeSql("drop temporary function if exists foo");
}
+ @Test
+ public void testTemporaryFunctionUDAF() throws Exception {
+ // create temp function
+ tableEnv.executeSql(
+ String.format(
+ "create temporary function temp_count as '%s'",
Review comment:
Could you like to test the udtf you define in this PR?
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/functions/hive/HiveGenericUDTFTest.java
##########
@@ -238,4 +242,28 @@ public void process(Object[] args) throws HiveException {
@Override
public void close() {}
}
+
+ /** Test split udtf initialize with StructObjectInspector. */
+ public static class TestSplitUDTFInitializeWithStructObjectInspector
extends GenericUDTF {
Review comment:
Move it to package org.apache.flink.table.functions.hive.util.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
