[
https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373200#comment-15373200
]
ASF GitHub Bot commented on FLINK-4143:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2219
The changes look good to me. Thanks for your work @zentol :-) I only had a
minor comment whether we should allow users to use a string as metric scope
delimiter.
Apart from that, +1 for merging.
> Configurable delimiter for metric identifier
> --------------------------------------------
>
> Key: FLINK-4143
> URL: https://issues.apache.org/jira/browse/FLINK-4143
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
>
> The metric identifier is currently hard-coded to separate components with a
> dot.
> We should make this configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
