[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374541#comment-15374541 ]
ASF GitHub Bot commented on FLINK-4143: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2219#discussion_r70577752 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) { } this.scopeFormats = scopeFormats; + char delim; + try { + delim = config.getString(ConfigConstants.METRICS_SCOPE_DELIMITER, ".").charAt(0); --- End diff -- Sorry, it was a hick-up of Github, because it didn't show me that I posted the comment so I thought I clicked on cancel. Why not changing `ScopeFormat.concat` such that it always takes a delimiter string as first parameter? Giving `""` as first argument will lead to the former variant where you don't specify a delimiter. > Configurable delimiter for metric identifier > -------------------------------------------- > > Key: FLINK-4143 > URL: https://issues.apache.org/jira/browse/FLINK-4143 > Project: Flink > Issue Type: Improvement > Components: Metrics > Affects Versions: 1.1.0 > Reporter: Chesnay Schepler > Assignee: Chesnay Schepler > Priority: Minor > > The metric identifier is currently hard-coded to separate components with a > dot. > We should make this configurable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)