Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2219#discussion_r70584088
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {
}
this.scopeFormats = scopeFormats;
+ char delim;
+ try {
+ delim =
config.getString(ConfigConstants.METRICS_SCOPE_DELIMITER, ".").charAt(0);
--- End diff --
well...sure it would work, but it will only be a matter of time until
someone forgets to pass a delimiter and gets the weirdest metric names
imaginable. I would simply *prefer* a solution that can catch this error at
compile-time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
