Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2219#discussion_r70475544
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {
}
this.scopeFormats = scopeFormats;
+ char delim;
+ try {
+ delim =
config.getString(ConfigConstants.METRICS_SCOPE_DELIMITER, ".").charAt(0);
--- End diff --
why do you post the same comment twice?
There isn't a particular reason for using a char. ScopeFormat.concat has a
var arg String argument, and as such couldn't differentiate between cases with
or without a delimiter. So i opted for the simple approach of using a char
instead of investing more time into a feature for something that IMO won't be
used anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
