tillrohrmann commented on a change in pull request #18028:
URL: https://github.com/apache/flink/pull/18028#discussion_r763892594
##########
File path: flink-jepsen/project.clj
##########
@@ -19,10 +19,11 @@
:url "http://www.apache.org/licenses/LICENSE-2.0"}
:main jepsen.flink.flink
:aot [jepsen.flink.flink]
- :dependencies [[org.clojure/clojure "1.9.0"],
+ :dependencies [;; jepsen 0.1.19 is not compatible with 1.10.1+
+ [org.clojure/clojure "1.10.0"],
[cheshire "5.8.0"]
[clj-http "3.8.0"]
- [jepsen "0.1.13"],
+ [jepsen "0.1.19"],
Review comment:
`0.2.5` is probably not working, right?
##########
File path: flink-jepsen/src/jepsen/flink/db.clj
##########
@@ -108,7 +108,12 @@
(teardown! [_ test node]
(c/su
(try
- (doseq [db (reverse dbs)] (db/teardown! db test node))
+ (doseq [db (reverse dbs)]
+ (try
+ (db/teardown! db test node)
+ ;; jepsen also calls teardown at the start of the test
+ ;; neither our dbs nor jepsen-zookeeper handle the db not
existing gracefully
Review comment:
How is Flink failing when calling teardown w/o having it started first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
