zentol commented on a change in pull request #18028:
URL: https://github.com/apache/flink/pull/18028#discussion_r763999905
##########
File path: flink-jepsen/src/jepsen/flink/db.clj
##########
@@ -108,7 +108,12 @@
(teardown! [_ test node]
(c/su
(try
- (doseq [db (reverse dbs)] (db/teardown! db test node))
+ (doseq [db (reverse dbs)]
+ (try
+ (db/teardown! db test node)
+ ;; jepsen also calls teardown at the start of the test
+ ;; neither our dbs nor jepsen-zookeeper handle the db not
existing gracefully
Review comment:
There are certainly cleaner ways to fix it, but this already took way
too much time. (The incompatibility with Clojure 1.10.1+ caught me off-guard,
and I kept trying to find some API change in Jepsen 😢 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
