dawidwys commented on a change in pull request #18024:
URL: https://github.com/apache/flink/pull/18024#discussion_r763993839
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
##########
@@ -129,6 +132,16 @@
+ "You need to allow this if you removed an
operator from your "
+ "program that was part of the program when the
savepoint was triggered.");
+ public static final Option SAVEPOINT_RESTORE_MODE =
+ new Option(
+ "r",
Review comment:
Yes, I still think it is fine to have a clash between options for
different commands.
The problem in the task you're referring is that it clashes with
`customCommandLineOptions` which are defined in custom command lines such as
e.g. yarn. We should probably add a check in the `mergeOptions` method to
verify there are no clashes.
As for this particular option (`r`), I could not find a clash in any of the
custom command lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
