dawidwys commented on a change in pull request #18001:
URL: https://github.com/apache/flink/pull/18001#discussion_r764638569
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedHaServicesWithLeadershipControl.java
##########
@@ -36,16 +40,23 @@ public EmbeddedHaServicesWithLeadershipControl(Executor
executor) {
this(
executor,
new
PerJobCheckpointRecoveryFactory<EmbeddedCompletedCheckpointStore>(
- (maxCheckpoints, previous) -> {
+ (maxCheckpoints, previous, stateRegistryFactory,
ioExecutor) -> {
+ List<CompletedCheckpoint> checkpoints =
+ previous != null
+ ? previous.getAllCheckpoints()
+ : Collections.emptyList();
+ SharedStateRegistry stateRegistry =
Review comment:
This is something the original PR tried to change. The original PRs
intention was not to recreate the `SharedStateRegistry` if we are not
recreating the `CompletedCheckpointStore`.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PerJobCheckpointRecoveryFactory.java
##########
@@ -38,7 +42,7 @@
public static <T extends CompletedCheckpointStore>
CheckpointRecoveryFactory
withoutCheckpointStoreRecovery(IntFunction<T> storeFn) {
return new PerJobCheckpointRecoveryFactory<>(
- (maxCheckpoints, previous) -> {
+ (maxCheckpoints, previous, sharedStateRegistry, ioExecutor) ->
{
Review comment:
```suggestion
(maxCheckpoints, previous, sharedStateRegistryFactory,
ioExecutor) -> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
