dawidwys commented on a change in pull request #18001:
URL: https://github.com/apache/flink/pull/18001#discussion_r765134835
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedHaServicesWithLeadershipControl.java
##########
@@ -36,16 +40,23 @@ public EmbeddedHaServicesWithLeadershipControl(Executor
executor) {
this(
executor,
new
PerJobCheckpointRecoveryFactory<EmbeddedCompletedCheckpointStore>(
- (maxCheckpoints, previous) -> {
+ (maxCheckpoints, previous, stateRegistryFactory,
ioExecutor) -> {
+ List<CompletedCheckpoint> checkpoints =
+ previous != null
+ ? previous.getAllCheckpoints()
+ : Collections.emptyList();
+ SharedStateRegistry stateRegistry =
Review comment:
Yes, you are obviously right. I was talking bollocks. I got completely
confused :(
Sorry for the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
