lindong28 commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764641563
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasK.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.common.param; + +import org.apache.flink.ml.param.IntParam; +import org.apache.flink.ml.param.Param; +import org.apache.flink.ml.param.ParamValidators; +import org.apache.flink.ml.param.WithParams; + +/** Interface for the shared K param. */ +public interface HasK<T> extends WithParams<T> { Review comment: @zhipeng93 @weibozhao If this parameter does not plan to be shared by multiple algorithms, could it be defined inside `KnnModelParams` (similar to how we define `k` in `KMeansModelParams`) instead being defined in `HasK`? If this parameter does intend to be shared by multiple algorithms, in addition to putting it in `HasK`, it is probably useful to use a class name that clearly specifies how it is going to be different from the `KMeansModelParams::K`. Note tha we may want to make `KMeansModelParams::K` a sharable parameter in the future as well. We will be good to think ahead and avoid ambiguous names. ########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasK.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.common.param; + +import org.apache.flink.ml.param.IntParam; +import org.apache.flink.ml.param.Param; +import org.apache.flink.ml.param.ParamValidators; +import org.apache.flink.ml.param.WithParams; + +/** Interface for the shared K param. */ +public interface HasK<T> extends WithParams<T> { Review comment: @zhipeng93 @weibozhao If this parameter does not plan to be shared by multiple algorithms, could it be defined inside `KnnModelParams` (similar to how we define `k` in `KMeansModelParams`) instead being defined in `HasK`? If this parameter does intend to be shared by multiple algorithms, in addition to putting it in `HasK`, it is probably useful to use a class name that clearly specifies how it is going to be different from the `KMeansModelParams::K`. Note tha we may want to make `KMeansModelParams::K` a sharable parameter in the future as well. It will be good to think ahead and avoid ambiguous names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
