pnowojski commented on a change in pull request #18024:
URL: https://github.com/apache/flink/pull/18024#discussion_r765532568
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendRunTest.java
##########
@@ -130,6 +131,46 @@ public void testRun() throws Exception {
}
}
+ @Test
+ public void testClaimRestoreModeParsing() throws Exception {
+ // test configure savepoint with claim mode
+ String[] parameters = {
+ "-s", "expectedSavepointPath", "-n", "-r", "claim",
getTestJarPath()
Review comment:
Ok, I see. I would personally be in favour of dropping the `-r`
abbreviation. IMO Those commands are used so rarely, that it doesn't make sense
to abbreviate them sacrificing readability. They will be either used once a
year, or written once in a script/code and then read many times. In both cases
abbreviation would do more harm than good.
But at the same time I'm not familiar and responsible for maintaining
consistency of our CLI, so I'm not sure what's are our conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
