zentol commented on pull request #107: URL: https://github.com/apache/flink-shaded/pull/107#issuecomment-990740416
> Would it really make things that more complex? I didn't say that complexity would shoot threw the roof. Just that it's _more_. How do you ensure that flink-shaded-netty bundles everything that Zookeeper actually needs? It may need at some point some optional netty thing, or we may cut out stuff from netty to save space. But to do that you need to be aware that there even is this coupling. The separation allows you to use flink-shaded-zookeeper with a newer netty version if the given netty version is not usable for the runtime/rest api. Similarly, we can bump the network/netty without affecting zookeeper. > this could be quite a lot Compared to bundling Scala 3 times, or even a single filesystem, it really isn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
