[
https://issues.apache.org/jira/browse/FLINK-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378902#comment-15378902
]
Tzu-Li (Gordon) Tai commented on FLINK-4194:
--------------------------------------------
I wonder if it would make more sense to name the method {{isEndOfShard()}}, and
stop a single {{ShardConsumer}} only when its {{true}}. This way the intention
of the method will be much more defined, and probably more useful for the user
too? Like you said, currently {{isEndOfStream()}} behaviour can't really be
defined, and I find it quite confusing myself.
What do you think?
> KinesisDeserializationSchema.isEndOfStream() is never called
> ------------------------------------------------------------
>
> Key: FLINK-4194
> URL: https://issues.apache.org/jira/browse/FLINK-4194
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Tzu-Li (Gordon) Tai
>
> The Kinesis connector does not respect the
> {{KinesisDeserializationSchema.isEndOfStream()}} method.
> The purpose of this method is to stop consuming from a source, based on input
> data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
