matriv commented on a change in pull request #18063:
URL: https://github.com/apache/flink/pull/18063#discussion_r767545558
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RawToStringCastRule.java
##########
@@ -57,11 +94,19 @@ protected String generateCodeBlockInternal(
.ifStmt(
deserializedObjTerm + " != null",
thenWriter ->
- thenWriter.assignStmt(
- returnVariable,
- CastRuleUtils.staticCall(
-
BINARY_STRING_DATA_FROM_STRING(),
-
methodCall(deserializedObjTerm, "toString"))),
+ CharacterFamilyTrimmingAndPaddingCastRule
Review comment:
Not really, because this rule returns a code block and not a single
expression, so our input is not already `BinaryStringData` as it happens for
example with `BooleanToString`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
