pnowojski commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r768435423



##########
File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
##########
@@ -467,7 +475,9 @@ private void createUploadFilePaths(
 
                 if (fileName.endsWith(SST_FILE_SUFFIX)) {
                     final boolean existsAlready =
-                            baseSstFiles != null && 
baseSstFiles.contains(stateHandleID);
+                            reuseSharedFiles
+                                    && baseSstFiles != null
+                                    && baseSstFiles.contains(stateHandleID);

Review comment:
       FYI (@rkhachatryan @dawidwys ) note, one you will have a conflict here 
with https://github.com/apache/flink/pull/17774




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to