dawidwys commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r768485412



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -135,7 +135,9 @@ public void triggerCheckpoint(long checkpointId) throws 
FlinkException {
                                             
CheckpointStorageLocationReference.getDefault(),
                                             
configuration.isExactlyOnceCheckpointMode(),
                                             
configuration.isUnalignedCheckpointsEnabled(),
-                                            
configuration.getAlignedCheckpointTimeout().toMillis());
+                                            
configuration.getAlignedCheckpointTimeout().toMillis(),
+                                            false /* TODO: we do not support 
no-claim mode with
+                                                  externally induced sources 
for now */);

Review comment:
       The reason is externally induced sources are quite broken already: 
https://issues.apache.org/jira/browse/FLINK-25256
   
   We decided with @pnowojski it should be fixed separately.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to