dawidwys commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r769486247
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1271,6 +1273,18 @@ private boolean performCheckpoint(
}
}
+ private void checkForcedFullSnapshotSupport(CheckpointOptions
checkpointOptions) {
+ if (checkpointOptions.isForcedFullSnapshot()
+ && !stateBackend.supportsForcedFullSnapshot()) {
+ throw new IllegalStateException(
Review comment:
I looked into it again and it's not that easy.
We don't have a reliable point in time in `StreamingJobGraphGenerator` where
we can say `SavepointRestoreSettings`(where we get `RestoreMode` from) won't
change. They are set afterwards e.g. in `PackagedProgramUtils#createJobGraph`.
Therefore we cannot put the check in `StreamingJobGraphGenerator`.
We know reliably about the `RestoreMode` in the
`CheckpointCoordinator#restoreSavepoint`. However, we don't have an easy acces
to the `StateBackend` there. Would you be ok leaving just this one check, the
way we have it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
