dawidwys commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r770273532
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
##########
@@ -179,6 +180,8 @@ public IncrementalRocksDBSnapshotResources
syncPrepareResources(long checkpointI
return new RocksDBIncrementalSnapshotOperation(
checkpointId,
+ checkpointOptions.getCheckpointType().getSharingFilesStrategy()
+ ==
CheckpointType.SharingFilesStrategy.FORWARD_BACKWARD,
checkpointStreamFactory,
snapshotResources.snapshotDirectory,
snapshotResources.baseSstFiles,
Review comment:
Sure it works.
My goal was to already provide a solution that could be easier changed to
`duplicate` instead of reupload, but as the change is so small it can be done
as part of https://issues.apache.org/jira/browse/FLINK-25195.
I changed to passing an empty set for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
