rkhachatryan commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r769936610
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
##########
@@ -179,6 +180,8 @@ public IncrementalRocksDBSnapshotResources
syncPrepareResources(long checkpointI
return new RocksDBIncrementalSnapshotOperation(
checkpointId,
+ checkpointOptions.getCheckpointType().getSharingFilesStrategy()
+ ==
CheckpointType.SharingFilesStrategy.FORWARD_BACKWARD,
checkpointStreamFactory,
snapshotResources.snapshotDirectory,
snapshotResources.baseSstFiles,
Review comment:
I've just noticed that this part can be simplified:
instead of passing and handling `reuseSharedFiles` to
`RocksDBIncrementalSnapshotOperation`;
we can just pass empty `baseSstFiles` (if sharingStrategy is not
`FORWARD_BACKWARD`).
`RocksDBIncrementalSnapshotOperation` doesn't have to be changed then. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
