Myasuka commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r771181730



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceOperatorStreamTask.java
##########
@@ -116,6 +116,11 @@ public void init() throws Exception {
             } else {
                 return super.triggerCheckpointAsync(checkpointMetaData, 
checkpointOptions);
             }
+        } else if (checkpointOptions.getCheckpointType() == 
CheckpointType.FULL_CHECKPOINT) {
+            // see FLINK-25256
+            throw new IllegalStateException(
+                    "NO_CLAIM mode is not supported in combination with 
externally induced"
+                            + " sources. Please use either CLAIM or LEGACY 
mode.");

Review comment:
       I think FULL_CHECKPOINT might be useful if we hope to enable to trigger 
manual checkpoint in the future. It's not better to bound them together.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to