Myasuka commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r771201269
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1261,6 +1269,10 @@ private void completePendingCheckpoint(PendingCheckpoint
pendingCheckpoint)
completedCheckpoint.getTimestamp(),
extractIdIfDiscardedOnSubsumed(lastSubsumed));
}
+
+ // reset the force full snapshot flag, we should've completed at least
on full snapshot by
+ // now
+ this.forceFullSnapshot = false;
Review comment:
If a savepoint is completed before triggering any checkpoint, this flag
would be reset as `false`, which is not as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
