[
https://issues.apache.org/jira/browse/FLINK-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382459#comment-15382459
]
ASF GitHub Bot commented on FLINK-4173:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2216#discussion_r71169047
--- Diff: flink-metrics/flink-metrics-ganglia/pom.xml ---
@@ -68,20 +68,27 @@ under the License.
<build>
<plugins>
<plugin>
- <artifactId>maven-assembly-plugin</artifactId>
- <version>2.4</version>
- <configuration>
- <descriptorRefs>
-
<descriptorRef>jar-with-dependencies</descriptorRef>
- </descriptorRefs>
- </configuration>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <version>2.4.1</version>
<executions>
+ <!-- Run shade goal on package phase -->
<execution>
- <id>make-assembly</id>
+ <id>shade-flink</id>
<phase>package</phase>
<goals>
- <goal>single</goal>
+ <goal>shade</goal>
</goals>
+ <configuration
combine.self="override">
+ <artifactSet>
+ <includes>
+
<include>org.apache.flink:flink-metrics-dropwizard</include>
+
<include>io.dropwizard.metrics:metrics-core</include>
+
<include>io.dropwizard.metrics:metrics-ganglia</include>
+
<include>info.ganglia.gmetric4j:gmetric4j</include>
--- End diff --
Sure that we don't need `org.acplt:oncrpc:jar:1.0.7:compile` which is a
transitive dependency of `info.ganglia.gmetric4j` in the fat jar? Have you
tried running ganglia on a cluster with this shaded jar?
> Replace maven-assembly-plugin by maven-shade-plugin in flink-metrics
> --------------------------------------------------------------------
>
> Key: FLINK-4173
> URL: https://issues.apache.org/jira/browse/FLINK-4173
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.1.0
>
>
> The modules {{flink-metrics-dropwizard}}, {{flink-metrics-ganglia}} and
> {{flink-metrics-graphite}} use the {{maven-assembly-plugin}} to build a fat
> jar. The resulting fat jar has the suffix {{jar-with-dependencies}}. In order
> to make the naming consistent with the rest of the system we should create a
> fat-jar without this suffix.
> Additionally we could replace the {{maven-assembly-plugin}} with the
> {{maven-shade-plugin}} to make it consistent with the rest of the system.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
