fapaul commented on a change in pull request #18105:
URL: https://github.com/apache/flink/pull/18105#discussion_r771370187



##########
File path: 
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainers.java
##########
@@ -254,6 +259,55 @@ public void submitSQLJob(SQLJobSubmission job) throws 
IOException, InterruptedEx
         }
     }
 
+    /**
+     * Submits the given job to the cluster.
+     *
+     * @param job job to submit
+     */
+    public JobID submitJob(JobSubmission job) throws IOException, 
InterruptedException {

Review comment:
       I have no hard feelings about the name of this method but I wanted to 
keep it consistent with the `ClusterController`[1] that is used for the current 
e2e tests. I thought it maybe makes the migration easier because developers are 
used to that name.
   
   [1] 
https://github.com/apache/flink/blob/master/flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/ClusterController.java#L37




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to