fapaul commented on pull request #18105: URL: https://github.com/apache/flink/pull/18105#issuecomment-996708378
> While I like the idea to only provide smoke tests on e2e, we should also ensure that we load as many classes as possible. So it may be necessary also to trigger the unhappy path to see if all failure handling related code is correctly shaded. I am not sure we will ever catch all the class loading issues in a smoke test. Once the user has access to the user classloader one can easily load new classes in arbitrary situations. Testing these scenarios IMO goes somewhat against a smoke test and should rather be covered differently. My idea is to keep the actual application logic for the testing as simple as possible i.e. simple reads and simple writes. > We should also do the same for the fat jar with SQL. I totally agree we also need something like this for the SQL submission -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
