ruanhang1993 commented on a change in pull request #18137:
URL: https://github.com/apache/flink/pull/18137#discussion_r772168389
##########
File path:
flink-test-utils-parent/flink-connector-testing/src/main/java/org/apache/flink/connectors/test/common/environment/MiniClusterTestEnvironment.java
##########
@@ -62,10 +63,26 @@ public MiniClusterTestEnvironment() {
}
@Override
- public StreamExecutionEnvironment createExecutionEnvironment() {
+ public StreamExecutionEnvironment createExecutionEnvironment(
+ ExecutionEnvironmentOptions envOptions) {
return StreamExecutionEnvironment.getExecutionEnvironment();
}
+ @Override
+ public Endpoint getRestEndpoint() {
+ try {
+ final URI restAddress =
this.miniCluster.getMiniCluster().getRestAddress().get();
+ return new Endpoint(restAddress.getHost(), restAddress.getPort());
+ } catch (Exception e) {
+ throw new RuntimeException("Failed to get REST endpoint of
MiniCluster", e);
+ }
+ }
+
+ @Override
+ public String getCheckpointUri() {
+ return null;
Review comment:
Why not use a temp folder? This may cause an NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
