slinkydeveloper commented on a change in pull request #18134:
URL: https://github.com/apache/flink/pull/18134#discussion_r772515313
##########
File path: flink-end-to-end-tests/flink-stream-sql-test/pom.xml
##########
@@ -30,19 +30,12 @@
<modelVersion>4.0.0</modelVersion>
- <artifactId>flink-stream-sql-test_${scala.binary.version}</artifactId>
+ <artifactId>flink-stream-sql-test</artifactId>
<name>Flink : E2E Tests : Stream SQL</name>
<packaging>jar</packaging>
<dependencies>
- <dependency>
- <groupId>org.apache.flink</groupId>
-
<artifactId>flink-streaming-scala_${scala.binary.version}</artifactId>
Review comment:
I don't think we should here, as these poms are often used by our users
to create their project configs, and in this case just
`flink-table-api-java-bridge` is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
