[ 
https://issues.apache.org/jira/browse/FLINK-25398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463582#comment-17463582
 ] 

Junfan Zhang commented on FLINK-25398:
--------------------------------------

[~Thesharing] Thanks for your advice. Agree with u, i will introduce the extra 
config to control the max depth.

Could you help tell me how to introduce new unit test to cover it? I have no 
ideas on it. :D. If just testing the rpc response and request, i think the 
previous UT is enough.

> Show complete stacktrace when requesting thread dump
> ----------------------------------------------------
>
>                 Key: FLINK-25398
>                 URL: https://issues.apache.org/jira/browse/FLINK-25398
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Junfan Zhang
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: stacktrace.png
>
>
> h2. Why
> Now the stacktrace is not complete when clicking the task executor's 
> threaddump  in runtime webui. Hence it's hard to the initial calling 
> according to the stacktrace.
> Now the thread stacktrace is limited to 8, refer to openjdk: 
> [https://github.com/openjdk/jdk/blob/master/src/java.management/share/classes/java/lang/management/ThreadInfo.java#L597]
>  
> h2. Solution
> Using the custom {{stringify}} method to return stacktrace instead of using 
> {{ThreadInfo.toString}} directly
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to