[
https://issues.apache.org/jira/browse/FLINK-25398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463694#comment-17463694
]
Zhilong Hong commented on FLINK-25398:
--------------------------------------
I think it may be a good idea to add a unit test for the method this patch
introduces, i.e. {{{}stringifyThreadInfo{}}}. If a configuration is added,
whether the configuration works must be tested. All available value of the
depth must be tested, too. Let's take an example: what would happen if the
depth is set to be 0? I think unit tests can help us make sure the function
works well and it won't be broken with future changes.
> Show complete stacktrace when requesting thread dump
> ----------------------------------------------------
>
> Key: FLINK-25398
> URL: https://issues.apache.org/jira/browse/FLINK-25398
> Project: Flink
> Issue Type: Improvement
> Reporter: Junfan Zhang
> Priority: Major
> Labels: pull-request-available
> Attachments: stacktrace.png
>
>
> h2. Why
> Now the stacktrace is not complete when clicking the task executor's
> threaddump in runtime webui. Hence it's hard to the initial calling
> according to the stacktrace.
> Now the thread stacktrace is limited to 8, refer to openjdk:
> [https://github.com/openjdk/jdk/blob/master/src/java.management/share/classes/java/lang/management/ThreadInfo.java#L597]
>
> h2. Solution
> Using the custom {{stringify}} method to return stacktrace instead of using
> {{ThreadInfo.toString}} directly
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
