Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2257#discussion_r71559450
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java
 ---
    @@ -113,7 +111,8 @@
        /** The service to find the right leader JobManager (to support high 
availability) */
        private final LeaderRetrievalService leaderRetriever;
     
    -   /** The currently registered resources */
    +   /** The resources which have been registered at the ResourceManager. 
This indicates the set
    +    * of containers where a TaskManager has been started and registered at 
a JobManager.  */
    --- End diff --
    
    Yes as you've said it in another comment, it does not represent TMs which 
are currently registered but TMs which are started and have at least once been 
registered. For the sake of simplicity, we could rename the field into 
`startedWorkers`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to