MartijnVisser commented on a change in pull request #18225:
URL: https://github.com/apache/flink/pull/18225#discussion_r776367861
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinarySection.java
##########
@@ -49,14 +49,17 @@ public void pointTo(MemorySegment[] segments, int offset,
int sizeInBytes) {
this.sizeInBytes = sizeInBytes;
}
+ @Override
public MemorySegment[] getSegments() {
return segments;
}
+ @Override
Review comment:
Same as above
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinarySection.java
##########
@@ -49,14 +49,17 @@ public void pointTo(MemorySegment[] segments, int offset,
int sizeInBytes) {
this.sizeInBytes = sizeInBytes;
}
+ @Override
public MemorySegment[] getSegments() {
return segments;
}
+ @Override
public int getOffset() {
return offset;
}
+ @Override
Review comment:
Same as above
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinarySection.java
##########
@@ -49,14 +49,17 @@ public void pointTo(MemorySegment[] segments, int offset,
int sizeInBytes) {
this.sizeInBytes = sizeInBytes;
}
+ @Override
Review comment:
I don't think these changes are relevant to the hotfix doc PR?
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/collector/TableFunctionCollector.java
##########
@@ -77,6 +77,7 @@ public boolean isCollected() {
return collected;
}
+ @Override
Review comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
