[
https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389265#comment-15389265
]
ASF GitHub Bot commented on FLINK-3901:
---------------------------------------
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2283
[FLINK-3901] [table] Create a RowCsvInputFormat for Table API
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
This PR is basically a Scala implementation of #1989. I removed some
unnecessary tests, reduced the number of constructors of `CsvRowInputFormat`
and fixed some smaller bugs.
@fpompermaier Could you again have a look at it?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-3901
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2283
----
commit 67c3b411071c7e9745bbf41111a9105cc00d348a
Author: Flavio Pompermaier <[email protected]>
Date: 2016-05-13T16:19:51Z
[FLINK-3901] [table] Create a RowCsvInputFormat to use as default CSV IF in
Table API
commit 3910e8a6d2989891277443b5e208b6168faf8196
Author: twalthr <[email protected]>
Date: 2016-07-22T09:26:43Z
[FLINK-3901] [table] Convert Java implementation to Scala and fix bugs
----
> Create a RowCsvInputFormat to use as default CSV IF in Table API
> ----------------------------------------------------------------
>
> Key: FLINK-3901
> URL: https://issues.apache.org/jira/browse/FLINK-3901
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 1.0.2
> Reporter: Flavio Pompermaier
> Assignee: Flavio Pompermaier
> Priority: Minor
> Labels: csv, null-values, row, tuple
>
> At the moment the Table APIs reads CSVs using the TupleCsvInputFormat, that
> has the big limitation of 25 fields and null handling.
> A new IF producing Row object is indeed necessary to avoid those limitations
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
