zhuzhurk commented on a change in pull request #18023:
URL: https://github.com/apache/flink/pull/18023#discussion_r776953526
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/TestingDefaultExecutionGraphBuilder.java
##########
@@ -157,12 +156,34 @@ public TestingDefaultExecutionGraphBuilder
setVertexParallelismStore(
return this;
}
- public TestingDefaultExecutionGraphBuilder setDynamicGraph(boolean
dynamicGraph) {
- this.isDynamicGraph = dynamicGraph;
- return this;
+ public DefaultExecutionGraph build() throws JobException,
JobExecutionException {
Review comment:
maybe add a private methods build(isDynamicGraph)?
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/TestingDefaultExecutionGraphBuilder.java
##########
@@ -157,12 +156,34 @@ public TestingDefaultExecutionGraphBuilder
setVertexParallelismStore(
return this;
}
- public TestingDefaultExecutionGraphBuilder setDynamicGraph(boolean
dynamicGraph) {
- this.isDynamicGraph = dynamicGraph;
- return this;
+ public DefaultExecutionGraph build() throws JobException,
JobExecutionException {
Review comment:
maybe add a private common methods build(isDynamicGraph)?
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/TestingDefaultExecutionGraphBuilder.java
##########
@@ -157,12 +156,34 @@ public TestingDefaultExecutionGraphBuilder
setVertexParallelismStore(
return this;
}
- public TestingDefaultExecutionGraphBuilder setDynamicGraph(boolean
dynamicGraph) {
- this.isDynamicGraph = dynamicGraph;
- return this;
+ public DefaultExecutionGraph build() throws JobException,
JobExecutionException {
Review comment:
maybe add a private common method build(isDynamicGraph)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
