zhuzhurk commented on a change in pull request #18023:
URL: https://github.com/apache/flink/pull/18023#discussion_r776954284
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java
##########
@@ -207,11 +209,40 @@ private static ExecutionJobVertex
createDynamicExecutionJobVertex(
final DefaultExecutionGraph eg =
TestingDefaultExecutionGraphBuilder.newBuilder().build();
final VertexParallelismStore vertexParallelismStore =
- SchedulerBase.computeVertexParallelismStoreForDynamicGraph(
+ computeVertexParallelismStoreForDynamicGraph(
Collections.singletonList(jobVertex),
defaultMaxParallelism);
final VertexParallelismInformation vertexParallelismInfo =
vertexParallelismStore.getParallelismInfo(jobVertex.getID());
return new ExecutionJobVertex(eg, jobVertex, vertexParallelismInfo);
}
+
+ // TODO: move to Adaptive Batch Scheduler.
+ /**
+ * Compute the {@link VertexParallelismStore} for all given vertices in a
dynamic graph, which
+ * will set defaults and ensure that the returned store contains valid
parallelisms, with the
+ * configured default max parallelism.
+ *
+ * @param vertices the vertices to compute parallelism for
+ * @param defaultMaxParallelism the global default max parallelism
+ * @return the computed parallelism store
+ */
+ @VisibleForTesting
Review comment:
`@VisibleForTesting` is not needed because it's part of tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
