[
https://issues.apache.org/jira/browse/FLINK-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389455#comment-15389455
]
Kanstantsin Kamkou commented on FLINK-4251:
-------------------------------------------
I'm not sure who created the first implementation, but the class design is
terrible. It makes no sense to fix the source (3 tickets already), and leave
sink with the same hard-coded queue declaration and private connection object.
Voting for this ticket. In the same time, I won't use the Flink's default
implementation. It is more reliable to create an own one with basic
functionality.
> Add possiblity for the RMQ Streaming Sink to customize the queue
> ----------------------------------------------------------------
>
> Key: FLINK-4251
> URL: https://issues.apache.org/jira/browse/FLINK-4251
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Reporter: Philipp Grulich
> Priority: Minor
>
> This patch adds the possibilty for the user of the RabbitMQ
> Streaming Sink to customize the queue which is used.
> This adopts the behavior of [FLINK-4025] for the sink.
> The commit doesn't change the actual behaviour but makes it
> possible for users to override the `setupQueue`
> method and customize their implementation. This was only possible for the
> RMQSource before. The Sink and the Source offer now both the same
> functionality, so this should increase usability.
> [FLINK-4025] = https://issues.apache.org/jira/browse/FLINK-4025
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
