[ 
https://issues.apache.org/jira/browse/FLINK-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389475#comment-15389475
 ] 

ASF GitHub Bot commented on FLINK-4251:
---------------------------------------

Github user kkamkou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2281#discussion_r71876785
  
    --- Diff: 
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
 ---
    @@ -58,6 +58,15 @@ public RMQSink(RMQConnectionConfig rmqConnectionConfig, 
String queueName, Serial
        }
     
        /**
    +    * Sets up the queue. The default implementation just declares the 
queue. The user may override
    +    * this method to have a custom setup for the queue (i.e. binding the 
queue to an exchange or
    +    * defining custom queue parameters)
    +    */
    +   protected void setupQueue() throws IOException {
    +           channel.queueDeclare(queueName, false, false, false, null);
    --- End diff --
    
    channel should be protected


> Add possiblity for the RMQ Streaming Sink to customize the queue
> ----------------------------------------------------------------
>
>                 Key: FLINK-4251
>                 URL: https://issues.apache.org/jira/browse/FLINK-4251
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming Connectors
>            Reporter: Philipp Grulich
>            Priority: Minor
>
> This patch adds the possibilty for the user of the RabbitMQ
> Streaming Sink to customize the queue which is used. 
> This adopts the behavior of [FLINK-4025] for the sink.
> The commit doesn't change the actual behaviour but makes it
> possible for users to override the `setupQueue`
> method and customize their implementation. This was only possible for the 
> RMQSource before. The Sink and the Source offer now both the same 
> functionality, so this should increase usability. 
> [FLINK-4025] = https://issues.apache.org/jira/browse/FLINK-4025



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to