slinkydeveloper commented on a change in pull request #18215:
URL: https://github.com/apache/flink/pull/18215#discussion_r777375933
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkCalciteSqlValidator.java
##########
@@ -126,17 +125,4 @@ public void validateColumnListParams(
// this makes it possible to ignore them in the validator and fall
back to regular row types
// see also SqlFunction#deriveType
}
-
Review comment:
I see the issue. I wonder if the proper nested validation of explain and
statement set can happen here as well, in addition of the code on the planner
side, as this seems the place where the validation belongs to. But I might be
mistaken here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
