JingsongLi commented on a change in pull request #18219:
URL: https://github.com/apache/flink/pull/18219#discussion_r777952061
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala
##########
@@ -384,6 +385,13 @@ abstract class PlannerBase(
}
val catalog =
toScala(catalogManager.getCatalog(objectIdentifier.getCatalogName))
val isTemporary = lookupResult.isTemporary
+
+ if (isManagedTable(catalog.get, resolvedTable) &&
+ !executor.isCheckpointingEnabled) {
+ throw new TableException(
+ s"Managed sink ${objectIdentifier} should enable the
checkpointing.")
Review comment:
`You should enable the checkpointing for sinking to managed table
${objectIdentifier}, managed table relies on checkpoint to commit and the data
is visible only after commit.`
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
