JingsongLi commented on a change in pull request #18219:
URL: https://github.com/apache/flink/pull/18219#discussion_r778496834



##########
File path: 
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/TableSinkTest.scala
##########
@@ -623,6 +623,32 @@ class TableSinkTest extends TableTestBase {
     // source and sink has same parallelism, but sink shuffle by pk is enforced
     util.verifyExplain(stmtSet, ExplainDetail.JSON_EXECUTION_PLAN)
   }
+
+  @Test
+  def testManagedTableSinkWithDisableCheckpointing(): Unit = {

Review comment:
       Can you add more tests:
   - streaming mode with cp
   - streaming mode without cp
   - batch mode




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to