slinkydeveloper commented on pull request #18255: URL: https://github.com/apache/flink/pull/18255#issuecomment-1005834631
@twalthr the reason for placing the classes in two places is to continue to use the asserts in table-common as well. > If it is only about DataStructureConverter we can also perform a class lookup whether flink-table-runtime is present or not That's something I can do with some reflections. This way, we can still use the assertions within table-common (without some methods that requires the runtime dep), and then we don't have duplicated code. But we'll still need the shading. Is it ok for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
