slinkydeveloper commented on a change in pull request #18255: URL: https://github.com/apache/flink/pull/18255#discussion_r779004352
########## File path: flink-table/flink-table-test-utils/pom.xml ########## @@ -0,0 +1,124 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table</artifactId> + <version>1.15-SNAPSHOT</version> + <relativePath>..</relativePath> + </parent> + + <artifactId>flink-table-test-utils</artifactId> + <name>Flink : Table : Test Utils</name> + <description> + This module contains test utilities for the Table API/SQL ecosystem. + </description> + + <packaging>jar</packaging> + + <dependencies> + <!-- Core test utils (MiniCluster) --> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-test-utils</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-test-utils-junit</artifactId> + <version>${project.version}</version> + <scope>compile</scope> + </dependency> + + <!-- Table dependencies required to create and run a SQL job --> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table-api-java-bridge</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table-runtime</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table-planner-loader</artifactId> + <version>${project.version}</version> + </dependency> + + <!-- We bring the assertions from flink-table-common and repackage them --> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table-common</artifactId> + <version>${project.version}</version> + <classifier>tests</classifier> + <type>test-jar</type> + <scope>compile</scope> + <!-- We don't want table-common to be used as transitive dependency --> + <optional>true</optional> + </dependency> + + <!-- Required for the assertions --> + <dependency> Review comment: `flink-test-utils` pulls `flink-test-utils-junit`, but we need to redeclare it here as the parent pom somewhere declares it with scope test, so we need to override the scope here. Removing `flink-test-utils-junit` returns this: ``` [INFO] org.apache.flink:flink-table-test-utils:jar:1.15-SNAPSHOT [INFO] +- org.apache.flink:flink-test-utils:jar:1.15-SNAPSHOT:compile [INFO] | +- org.apache.flink:flink-test-utils-junit:jar:1.15-SNAPSHOT:test ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
