[
https://issues.apache.org/jira/browse/FLINK-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390674#comment-15390674
]
ASF GitHub Bot commented on FLINK-3866:
---------------------------------------
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2289
[FLINK-3866] StringArraySerializer type should be mutable
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mushketyk/flink mutable-array
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2289
----
commit 4edb12cfc13c06ca1fb19dfb7042795cf883719c
Author: Ivan Mushketyk <[email protected]>
Date: 2016-07-23T09:39:24Z
[FLINK-3866] StringArraySerializer type should be mutable
----
> StringArraySerializer claims type is immutable; shouldn't
> ---------------------------------------------------------
>
> Key: FLINK-3866
> URL: https://issues.apache.org/jira/browse/FLINK-3866
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.3
> Reporter: Tatu Saloranta
> Assignee: Ivan Mushketyk
> Priority: Minor
>
> Looking at default `TypeSerializer` instances I noticed what looks like a
> minor flaw, unless I am missing something.
> Whereas all other array serializers indicate that type is not immutable
> (since in Java, arrays are not immutable), `StringArraySerializer` has:
> ```
> @Override
> public boolean isImmutableType() {
> return true;
> }
> ```
> and I think it should instead return `false`. I could create a PR, but seems
> like a small enough thing that issue report makes more sense.
> I tried looking for deps to see if there's a test for this, but couldn't find
> one; otherwise could submit a test fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
