alpreu commented on a change in pull request #17819:
URL: https://github.com/apache/flink/pull/17819#discussion_r780108035
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/KerberosMountDecorator.java
##########
@@ -198,10 +199,10 @@ public FlinkPod decorateFlinkPod(FlinkPod flinkPod) {
}
public static String getKerberosKeytabSecretName(String clusterId) {
- return Constants.KERBEROS_KEYTAB_SECRET_PREFIX + clusterId;
+ return KubernetesLabel.create(clusterId,
KubernetesLabel.KERBEROS_KEYTAB_SECRET_PREFIX);
}
- public static String getKerberosKrb5confConfigMapName(String clusterID) {
- return Constants.KERBEROS_KRB5CONF_CONFIG_MAP_PREFIX + clusterID;
+ public static String getKerberosKrb5confConfigMapName(String clusterId) {
+ return KubernetesLabel.create(clusterId,
KubernetesLabel.KERBEROS_KEYTAB_SECRET_PREFIX);
Review comment:
Good catch
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -220,7 +220,7 @@
.withDescription(
Description.builder()
.text(
- "The cluster-id, which should be
no more than 45 characters, is used for identifying a unique Flink cluster. "
+ "The cluster-id, which should be
no more than 40 characters, is used for identifying a unique Flink cluster. "
Review comment:
Yes, it changed back to the original value. The reason is that the 40
was derived from the `"-resourcemanager-leader"` in `KubernetesHaServices`. In
that class only configmap names are generated, for which the 63 character limit
does not apply. I don't know if it makes sense to move this generation also
into `KubernetesLabel`. Especially because the JobManager one does contain the
`JobID` which would restrict the clusterId length extremely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
