[
https://issues.apache.org/jira/browse/FLINK-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391975#comment-15391975
]
ASF GitHub Bot commented on FLINK-3904:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2123#discussion_r72071650
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -84,12 +84,11 @@
*/
private static int MAX_SAMPLE_LEN;
- static { loadGlobalConfigParams(); }
-
- protected static void loadGlobalConfigParams() {
- int maxSamples =
GlobalConfiguration.getInteger(ConfigConstants.DELIMITED_FORMAT_MAX_LINE_SAMPLES_KEY,
+
+ protected static void loadConfigParameters(Configuration parameters) {
--- End diff --
I think this is a public API change. The class is annotated with `@Public`
and the method is `protected`, which means that some users might have extended
this input format and rely on this method. What do you think?
> GlobalConfiguration doesn't ensure config has been loaded
> ---------------------------------------------------------
>
> Key: FLINK-3904
> URL: https://issues.apache.org/jira/browse/FLINK-3904
> Project: Flink
> Issue Type: Improvement
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 1.1.0
>
>
> By default, {{GlobalConfiguration}} returns an empty Configuration. Instead,
> a call to {{get()}} should fail if the config hasn't been loaded explicitly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
