[ 
https://issues.apache.org/jira/browse/FLINK-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392038#comment-15392038
 ] 

ASF GitHub Bot commented on FLINK-3904:
---------------------------------------

Github user uce commented on the issue:

    https://github.com/apache/flink/pull/2123
  
    Very good work Max! The changes look good to me and I think it's much 
cleaner this way. The `DelimitedInputFormat` API change question needs to be 
addressed before merging I think.
    
    Regarding the other "API breaking" changes I'm undecided right now. I fully 
agree that they are not documented and hence should be fine to remove. On the 
other hand, the code is not expensive to maintain and if someone is relying on 
loading of multiple YAML files for example, that will be hard to debug for the 
user. I feel like it might make sense to get more community feedback before 
merging this for 1.1 release. What do you think?


> GlobalConfiguration doesn't ensure config has been loaded
> ---------------------------------------------------------
>
>                 Key: FLINK-3904
>                 URL: https://issues.apache.org/jira/browse/FLINK-3904
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> By default, {{GlobalConfiguration}} returns an empty Configuration. Instead, 
> a call to {{get()}} should fail if the config hasn't been loaded explicitly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to