alpreu opened a new pull request #18319:
URL: https://github.com/apache/flink/pull/18319


   ## What is the purpose of the change
   
   testRetryComittableORetriableError is taking over an hour on CI runs. We 
want to speed up the test.
   The KafkaProducer doc states:
   
   ````
   * <p>
   * To enable idempotence, the <code>enable.idempotence</code> configuration 
must be set to true. If set, the
   * <code>retries</code> config will default to <code>Integer.MAX_VALUE</code> 
and the <code>acks</code> config will
   * default to <code>all</code>. There are no API changes for the idempotent 
producer, so existing applications will
   * not need to be modified to take advantage of this feature.
   * </p>
   ```
   
   The issue is therefore that we retry MAX_VALUE times. This PR sets the 
number of retries to 3.
   
   ## Brief change log
   
   - set ProducerConfig option 'retries' to 3.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
    * CI run for test_ci_build kafka_gelly should be significantly faster. 
Compare with previous runs (> 1hr)
   * Log of producer config values should show 'retries = 3'
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (JavaDocs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to